-
Notifications
You must be signed in to change notification settings - Fork 153
Include qcom.config in KBUILD_CONFIG_EXTRA of linux-qcom-next recipe #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| KBUILD_CONFIG_EXTRA = "${@bb.utils.contains('DISTRO_FEATURES', 'hardened', '${S}/kernel/configs/hardening.config', '', d)}" | ||
| KBUILD_CONFIG_EXTRA:append:aarch64 = "${S}/arch/arm64/configs/prune.config" | ||
| KBUILD_CONFIG_EXTRA:append:aarch64 = " ${S}/arch/arm64/configs/prune.config" | ||
| KBUILD_CONFIG_EXTRA:append:aarch64 = " ${S}/arch/arm64/configs/qcom.config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is provided by the kernel tree, but we also have a qcom.cfg fragment (and now qcom.config), not an issue necessarily but might cause confusion later on (what is in tree and what is provided by the recipe).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The in-tree qcom.config fragment and the recipe-provided qcom.cfg fragment are already in separate lists, so users can identify the source. However, similar naming still creates confusion. I’ve created GH issue #1252 to track this.
Test run workflowTest jobs for commit 390b602
|
Test Results 14 files ± 0 23 suites - 5 1h 21m 1s ⏱️ + 43m 33s For more details on these failures, see this check. Results for commit 793298f. ± Comparison against base commit 026ef6f. ♻️ This comment has been updated with latest results. |
Add a leading space when appending prune.config to KBUILD_CONFIG_EXTRA. Without this, configs may concatenate incorrectly, causing build issues. This addresses a regression introduced by commit d1e9628. Signed-off-by: Viswanath Kraleti <[email protected]>
`qcom.config`, a Qualcomm-specific kernel configuration fragment enables features and subsystems required by Qualcomm SoCs that are not part of the community's common defconfig. Add qcom.config to KBUILD_CONFIG_EXTRA to enable these essential features and subsystems on aarch64 builds. Signed-off-by: Viswanath Kraleti <[email protected]>
Remove DMABUF HEAP related configs and CONFIG_SCSI_UFS_QCOM from qcom.cfg since these are already enabled in the in-tree qcom.config. Signed-off-by: Viswanath Kraleti <[email protected]>
390b602 to
793298f
Compare
Test run workflowTest jobs for commit 793298f
|
|
Apparently ICE-related configurations enabled in I’ll move this PR to draft for now and will make it active once the ICE fixes are merged into the qcom-next kernel. |
Interesting, I did see some some ice-related issues with ubuntu as well (which has all the ice options enabled), could just be an upstream issue. |
qcom.config, a Qualcomm-specific kernel configuration fragmentenables features and subsystems required by Qualcomm SoCs that are
not part of the community's common defconfig.
Add qcom.config to KBUILD_CONFIG_EXTRA to enable these essential
features and subsystems on aarch64 builds.